Skip to content

Kotlin: Handle null parent IDs in getFunctionLabel correctly #13944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2023
Merged

Kotlin: Handle null parent IDs in getFunctionLabel correctly #13944

merged 1 commit into from
Aug 11, 2023

Conversation

igfoo
Copy link
Contributor

@igfoo igfoo commented Aug 10, 2023

They were being stringified into null strings before. Now we check for nullness, and return null if appropriate.

@igfoo igfoo marked this pull request as ready for review August 10, 2023 19:37
@igfoo igfoo requested a review from a team as a code owner August 10, 2023 19:37
@igfoo igfoo merged commit 5161cd1 into github:main Aug 11, 2023
@igfoo igfoo deleted the igfoo/getFunctionLabel branch August 11, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smowton smowton smowton approved these changes

Assignees
No one assigned
Labels
Kotlin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igfoo @smowton