Skip to content

Make CompareIdenticalValues test work on arm64 #13948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

mbg
Copy link
Member

@mbg mbg commented Aug 11, 2023

The constants.go file has a build tag which means that it doesn't get compiled on arm64 and therefore the ptrsize constant is undefined in tst.go, causing the consistency test to fail.

This PR updates the build tags for constants.go so that it gets included on arm64 as well.

@mbg mbg requested a review from a team as a code owner August 11, 2023 09:53
@github-actions github-actions bot added the Go label Aug 11, 2023
@mbg mbg merged commit 9f51f6f into main Aug 11, 2023
@mbg mbg deleted the mbg/go/fix-compare-identical-values-arm64 branch August 11, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants