Skip to content

C#: Poor mans quoting. #14172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2023
Merged

C#: Poor mans quoting. #14172

merged 2 commits into from
Sep 11, 2023

Conversation

michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Sep 8, 2023 •
edited
Loading

If quoted arguments are used these will not be respected by the LUA tracer on windows.
In this PR we explicitly quote all compiler arguments containing whitespaces (windows only) in the dotnet matcher.
This is an initial fix. The full fix, which also depends on an internal PR will be merged here: #14150

@github-actions github-actions bot added the C# label Sep 8, 2023
Lizzyrobin4
Lizzyrobin4 reviewed Sep 8, 2023
View reviewed changes
Copy link

@Lizzyrobin4 Lizzyrobin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and let it work perfectly on my device

@Lizzyrobin4
Copy link

Good and let it work perfectly on my device

@michaelnebel
Copy link
Contributor Author

@aibaars : Should we consider merging this PR instead of the full solution as an intermediate?
As far as I can tell we don't break any existing stuff as we are checking for the presence of a whitespace before quoting. We might still return garbage in some cases, but then it will be garbage in - garbage out.

@michaelnebel michaelnebel requested a review from aibaars September 8, 2023 13:51
@michaelnebel michaelnebel marked this pull request as ready for review September 11, 2023 06:14
@michaelnebel michaelnebel requested a review from a team as a code owner September 11, 2023 06:14
@michaelnebel
Copy link
Contributor Author

DCA looks good!

@michaelnebel michaelnebel mentioned this pull request Sep 11, 2023
Closed
@michaelnebel michaelnebel merged commit 1b90216 into github:main Sep 11, 2023
@michaelnebel michaelnebel deleted the csharp/poormansquoting branch September 11, 2023 06:57
@michaelnebel michaelnebel mentioned this pull request Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aibaars aibaars Awaiting requested review from aibaars

2 more reviewers

@Lizzyrobin4 Lizzyrobin4 Lizzyrobin4 left review comments

@tamasvajk tamasvajk tamasvajk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
C#
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelnebel @Lizzyrobin4 @tamasvajk