Swift: Consistent additional taint steps between the cleartext-* queries #14189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tabase query to the other sensitive data queries.
|
DCA run looks clean. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional taint steps to the
swift/cleartext-transmission,swift/cleartext-loggingandswift/cleartext-storage-preferencesqueries similar to an existing additional taint step in theswift/cleartext-storage-databasequery. This identifies data within a container that matches the sensitive data heuristic as sensitive as well, for examplevaluein:I've also added some tests and converted a couple of existing sinks to CSV.