Skip to content

C++: Fix order of non-linear join in range analysis #14237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2023
Merged

C++: Fix order of non-linear join in range analysis #14237

merged 1 commit into from
Sep 18, 2023

Conversation

MathiasVP
Copy link
Contributor

@MathiasVP MathiasVP commented Sep 16, 2023 •
edited
Loading

DCA had some random failures on all the Windows runners, but this seems to speedup the main recursion. I think the explanation is two fold:

  • By lifting noOverflow out we give the compiler a smaller predicate whose prev and prev_delta can be used in the recursion.
  • By restricting out initialBoundedLower and initialBoundedUpper we make sure that the joins with initialBounded_prev are restricted as much as possible before we join with them.

@github-actions github-actions bot added the C++ label Sep 16, 2023
@MathiasVP MathiasVP marked this pull request as ready for review September 18, 2023 08:39
@MathiasVP MathiasVP requested a review from a team as a code owner September 18, 2023 08:39
@MathiasVP MathiasVP added the no-change-note-required This PR does not need a change note label Sep 18, 2023
geoffw0
geoffw0 approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks correct to me.

The DCA run is a little hard to read, but I take some comfort from the overall analysis time being a slight speedup.

@MathiasVP MathiasVP merged commit 734a91d into github:main Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffw0 geoffw0 geoffw0 approved these changes

Assignees
No one assigned
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MathiasVP @geoffw0