C#: Parallelize restore logic of missing packages #14243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/DependencyManager.cs
Fixed
Show fixed
Hide fixed
tamasvajk
force-pushed
the
parallelize-restore
branch
2 times, most recently
from
b04c661 to
294b0f5
Compare
tamasvajk
force-pushed
the
parallelize-restore
branch
from
2388027 to
c78cd73
Compare
|
Sample log messages when running work on multiple threads:
|
michaelnebel
approved these changes
Sep 20, 2023
| }) | ||
| .ToList(); | ||
| foreach (var line in stdoutLines) | ||
| Parallel.ForEach(projects, new ParallelOptions { MaxDegreeOfParallelism = options.Threads }, project => |
There was a problem hiding this comment.
Out of curiosity: Did you measure the performance impact of using this "Parallel" library instead of PLINQ?
There was a problem hiding this comment.
In any case, this is much nicer :-)
There was a problem hiding this comment.
I haven't. But I'm under the impression that they do the same.
| var threadId = $"[{Environment.CurrentManagedThreadId:D3}]"; | ||
| void onOut(string s) | ||
| { | ||
| Console.Out.WriteLine($"{threadId} {s}"); |
There was a problem hiding this comment.
nit: Could be inlined as lambdas?
There was a problem hiding this comment.
Yes, it could be. (I think in general local functions perform better than lambdas. But not in this case, because we're passing the local function as an Action delegate.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
DependencyManager.DownloadMissingPackages,Processstarting logic.Commit-by-commit review is suggested.