C#: Extract compilation DB entity in standalone mode #14351
Conversation
tamasvajk
force-pushed
the
csharp/standalone-compilation
branch
from
176f4db to
de45a9b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| catch (Exception ex) // lgtm[cs/catch-of-all-exceptions] | ||
| { | ||
| Logger.Log(Severity.Error, " Unhandled exception analyzing {0}: {1}", "compilation", ex); | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause
| catch | ||
| { } |
Check notice
Code scanning / CodeQL
Poor error handling: empty catch block
| catch | ||
| { } |
Check notice
Code scanning / CodeQL
Generic catch clause
|
DCA looks okay: There are differences in the results of |
| @@ -143,5 +143,37 @@ public static string NestPaths(ILogger logger, string? outerpath, string innerpa | |||
| } | |||
| return nested; | |||
| } | |||
|
|
|||
| public static string GetTemporaryWorkingDirectory(out bool shouldCleanUp) | |||
There was a problem hiding this comment.
Maybe it makes sense to put these methods in class that implements IDisposable to ensure that cleanup happens if needed? Could TemporaryDirectory be re-used with some extra exposed methods?
There was a problem hiding this comment.
The cleanup of the temporary directory is somewhat error prone. At the moment we basically expect the temporary directory to be cleaned up only at (or close to) application exit. Putting it in a more reusable class would suggest that you can dispose it any time, but that would break the application, because we currently store generated source files in this folder too.
| { | ||
| progressMonitor.MissingNamespace(type); | ||
| } | ||
| var output = FileUtils.CreateTemporaryFile(".dll", out var shouldCleanUpContainingFolder); |
There was a problem hiding this comment.
Could we risk that anyone relies on us producing a csharp.dll for traced extraction?
Maybe we need a change note.
There was a problem hiding this comment.
csharp.dll was only used for standalone extraction, so I think changing it won't cause any major issue for anyone.
There was a problem hiding this comment.
Oh, of course - you are right.
| this.options = options; | ||
| LogExtractorInfo(Extraction.Extractor.Version); | ||
| SetReferencePaths(); | ||
|
|
||
| Entities.Compilation.Settings = (Directory.GetCurrentDirectory(), Array.Empty<string>()); |
There was a problem hiding this comment.
For consistency: Can this be put in the Run method for the standalone extractor like it happens in the tracing extractor?
There was a problem hiding this comment.
We can't, because the Run method is in Semmle.Extraction.CSharp.Standalone and Compilation is internal.
No description provided.