Skip to content

Swift: Add sinks for the GRDB database library to swift/hardcoded-key #14407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Oct 9, 2023

Add sinks for the GRDB database library to swift/hardcoded-key. That is, model the functions in that library that deal with encryption keys.

@geoffw0 geoffw0 added the Swift label Oct 9, 2023
@geoffw0 geoffw0 requested a review from a team as a code owner October 9, 2023 07:48
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@geoffw0
Copy link
Contributor Author

geoffw0 commented Oct 9, 2023

DCA looks clean (unsurprisingly). Merging...

@geoffw0 geoffw0 merged commit 62b0ebf into github:main Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants