Skip to content

Python: Add missing flow for AssignmentExpr nodes #14417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

tausbn
Copy link
Contributor

@tausbn tausbn commented Oct 9, 2023

Also extend the tests surrounding this construct to be a bit more comprehensive.

Also extend the tests surrounding this construct to be a bit more comprehensive.

Co-authored-by: Rasmus Lerchedahl Petersen <yoff@github.com>
@tausbn tausbn added the no-change-note-required This PR does not need a change note label Oct 9, 2023
@github-actions github-actions bot added the Python label Oct 9, 2023
@yoff
Copy link
Contributor

yoff commented Oct 10, 2023

The failures are just the consistency violations moving due to added lines in the tests file.

Co-authored-by: Rasmus Lerchedahl Petersen <yoff@github.com>
@tausbn tausbn marked this pull request as ready for review October 10, 2023 11:55
@tausbn tausbn requested a review from a team as a code owner October 10, 2023 11:55
Copy link
Contributor

@yoff yoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoff yoff merged commit f1266a3 into main Oct 10, 2023
@yoff yoff deleted the tausbn/python-add-flow-for-assignment-expressions branch October 10, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-change-note-required This PR does not need a change note Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants