C#: Add autobuilder test with global.json #14421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
approved these changes
Oct 10, 2023
|
We probably need to run the tests again after the semmle-code have been merged. |
hvitved
approved these changes
Oct 10, 2023
The same test is run in the linked PR with the required changes. The test passes there. (But there are unrelated CI failures) |
Unfortunately, this was not the only blocking issue. :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an autobuilder integration test with a global.json file. The test fails on windows because the dotnet-install script fails. We need the
PROCESSOR_ARCHITECTUREenvironment variable for the script to succeed.