-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Java: basic version of automodel extraction query docs #14487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@adityasharad: I've promised to ping you once I've written about why there are framework mode candidates that are both sink candidates as well as source candidates. The section called "Parameters as Source Candidates" tries to explain that. 🙂 @aeisenberg: I've also promised to ping you! 👋 👍 No review is required, but always welcome of course :) |
a01c34b
to
e97456f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Mostly very minor copy-editing suggestions. My only bigger comment is around including a sentence or two describing what these queries are used for.
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
Co-authored-by: Aditya Sharad <6874315+adityasharad@users.noreply.github.com>
Thank you for the reviews, @adityasharad and @aeisenberg! I've responded 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Looks good.
This adds documentation for the Java extraction queries.
Much of this content is writing down "lore" that accumulated over building and maintaining these queries.
I've tried to stick to information that I would find difficult to get across as comments in the ql/qll files.
Dear Reviewer