Swift: Models for String methods involving closures. #14578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed a merge conflict. |
rdmarsh2
reviewed
Oct 25, 2023
Comment on lines
+71
to
+72
| ";StringProtocol;true;withCString(_:);;;Argument[-1];Argument[0].Parameter[0].CollectionElement;taint", | ||
| ";StringProtocol;true;withCString(_:);;;Argument[0].ReturnValue;ReturnValue;value", |
There was a problem hiding this comment.
Should there be a step from the mutated parameter of the callback to the this parameter of the method?
There was a problem hiding this comment.
Discussed on the other comment.
Comment on lines
+136
to
+137
| ";String;true;withPlatformString(_:);;;Argument[-1];Argument[0].Parameter[0].CollectionElement;taint", | ||
| ";String;true;withPlatformString(_:);;;Argument[0].ReturnValue;ReturnValue;value", |
There was a problem hiding this comment.
I don't think you can mutate the string with these particular methods. I'll check...
There was a problem hiding this comment.
Sorry for taking a while to get back to this. I think it's only possible to modify the object using the methods marked mutating, that is withMutableCharacters and withUTF8 in this PR (and I'm not sure it's practically possible with the latter, see the doc).
Some experimentation here - notice that the changes are never reflected back in s.
rdmarsh2
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add flow models for
Stringmethods involving closures, such asString.withUTF8(_:). Most already had test coverage, but I did have to add tests forwithMutableCharacters(_:)and an additional test forString(unsafeUninitializedCapacity:initializingUTF8With:)to show that the model is working despite other issues in the existing test. Unfortunately the diff of the test is also polluted by a renumbering.