Skip to content

Java: exclude internal packages globally from MaD models #14581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jcogs33
Copy link
Contributor

@jcogs33 jcogs33 commented Oct 24, 2023

We currently exclude only JDK internals from MaD models. This PR excludes any models with %internal% in their package name since such models have come up during ML and heuristic triage.

Let me know if there is any reason not to apply this exclusion.

@github-actions github-actions bot added the Java label Oct 24, 2023
@jcogs33 jcogs33 added the no-change-note-required This PR does not need a change note label Oct 24, 2023
@jcogs33 jcogs33 marked this pull request as ready for review October 24, 2023 17:39
@jcogs33 jcogs33 requested a review from a team as a code owner October 24, 2023 17:39
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jcogs33 jcogs33 merged commit 53d92d5 into github:main Oct 25, 2023
@jcogs33 jcogs33 deleted the jcogs33/add-internal-to-model-exclusions branch October 25, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants