Dataflow: Restrict partial flow to either forward or reverse flow. #14599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
previously approved these changes
Oct 26, 2023
There was a problem hiding this comment.
LGTM! I guess we should also update the reference to FlowExploration in https://codeql.github.com/docs/writing-codeql-queries/debugging-data-flow-queries-using-partial-flow/ (or make FlowExploration an alias for FlowExplorationFwd)?
The doc needs an update regardless as the info about reverse flow needs a fix. |
MathiasVP
approved these changes
Oct 26, 2023
It's very minor, so I think your review is plenty. |
|
Do you need to update the test queries in |
Gah! Of course CI didn't run. |
This was referenced Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using partial flow we would calculate both partial forward flow and partial reverse flow even though only one direction was requested. This moves the choice into the parameterised module application so we know up front which one to calculate. So instead of always using
module Partial = FlowExploration<limit/0>and choosing betweenPartial::partialFlowandPartial::partialFlowRev, you now choose betweenmodule Partial = FlowExplorationFwd<limit/0>andmodule Partial = FlowExplorationRev<limit/0>, and then always usePartial::partialFlow.