Skip to content

Go: mark all integration tests non-parallelisable #14640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

smowton
Copy link
Contributor

@smowton smowton commented Oct 30, 2023

go get has been observed to sometimes fail when multiple tests try to simultaneously fetch the same package.

@smowton smowton requested a review from a team as a code owner October 30, 2023 22:16
@github-actions github-actions bot added the Go label Oct 30, 2023
@@ -0,0 +1 @@
# go get has been observed to sometimes fail when multiple tests try to simultaneously fetch the same package.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also have a non-comment line with, let's say
goget?
Otherwise, this gets assigned the default group, which (for backwards compatibility reasons) is gradle, which isn't the group you want to be in

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@smowton smowton merged commit 98032d5 into main Oct 31, 2023
@smowton smowton deleted the smowton/admin/make-go-tests-serial branch October 31, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants