JS: remove the remaining yarn files #14686
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In that case I should probably not delete it in my typescript upgrade PR ;-) |
aibaars
approved these changes
Nov 6, 2023
criemen
approved these changes
Nov 6, 2023
|
Ehhh. This PR was merged (as seen in the But the UI says I closed the PR.... |
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Nov 6, 2023
JS: remove the remaining yarn files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JS extractor has moved from
yarntonpm, so we should be able to delete these files.We already had a
package-lock.jsonfile (that I accidentally committed a while ago) in the directory, but now we actually need it.The CI failure is unrelated, and I have reported it to the relevant team.Fixed.