C#: Deprecate UnboundGenericType::getInstanceType/0
#14688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
reviewed
Nov 6, 2023
| @@ -127,7 +127,7 @@ class UnboundGenericType extends ValueOrRefType, UnboundGeneric { | |||
| * is a constructed type created from the unbound type, with each of the supplied type | |||
| * arguments being the corresponding type parameter. | |||
| */ | |||
| ConstructedType getInstanceType() { | |||
| deprecated ConstructedType getInstanceType() { | |||
There was a problem hiding this comment.
Should there be a deprecation message?
hvitved
force-pushed
the
csharp/deprecate-get-instance-type
branch
from
fc81f3c to
12cd1c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This predicate would never contain any tuples, given that the extractor considers a constructed type
C<T1, ..., Tn>, whereTiis theith type parameter ofC, identical with the unbound generic typeC`n.