Skip to content

Swift: Use TaintInheritingContent in WebView.qll #14772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 14, 2023
Merged

Swift: Use TaintInheritingContent in WebView.qll #14772

merged 2 commits into from
Nov 14, 2023

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Nov 13, 2023

Modernize tainted content in WebView.qll by using TaintInheritingContent instead of an AdditionalTaintStep.

@geoffw0 geoffw0 added no-change-note-required This PR does not need a change note Swift labels Nov 13, 2023
@geoffw0 geoffw0 requested a review from a team as a code owner November 13, 2023 18:43
@geoffw0 geoffw0 changed the title Swift: Use TaintInheritingContent in WebView.qll` Swift: Use TaintInheritingContent in WebView.qll Nov 13, 2023
MathiasVP
MathiasVP approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once we have a successful DCA run!

@geoffw0
Copy link
Contributor Author

geoffw0 commented Nov 14, 2023

DCA looks clean.

@geoffw0 geoffw0 merged commit 0342b3e into github:main Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathiasVP MathiasVP MathiasVP approved these changes

Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geoffw0 @MathiasVP