Ruby: Prune irrelevant data flow nodes and edges #14787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
ruby/prune-dataflow-nodes
branch
2 times, most recently
from
5c7ba84 to
d648548
Compare
hvitved
force-pushed
the
ruby/prune-dataflow-nodes
branch
from
d648548 to
b2f1022
Compare
aibaars
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some irrelevant data flow nodes and edges, reported by the consistency checks of the shared type tracking library:
ReturningNodes to those that may actually return a value.Synth(Hash)SplatArgumentNodes to those into which we may actually do an implicit store.HashSplatContents to symbols, as only symbols can be mapped to parameters.