Java Automodel extraction: fix extracted meta information by using Object for the type of generic parameters #14818
+10
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject for the type of generic parameters
atorralba
approved these changes
Nov 16, 2023
Well spotted! The reason: I recreated the changes on a fresh branch to avoid a complicated history due to merge conflicts with another fix I merged today; when recreating, I decided I don't need a NEW test case because there was already an example of such a class in the existing code. I've offered to fix the occurrence in |
kaeluka
deleted the
kaeluka/application-mode-erase-type-signatures-of-generic-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@atorralba thanks for pointing me in the right direction. Could you give this a quick review? I think it should not be surprising any more 👍