C#: Strengthen call-back heuristics by considering body-less methods #14832
Conversation
hvitved
force-pushed
the
csharp/callback-heuristics
branch
5 times, most recently
from
302add9 to
393628a
Compare
hvitved
force-pushed
the
csharp/callback-heuristics
branch
from
393628a to
ccb9d9b
Compare
| not c.hasBody() and | ||
| (if c instanceof AddEventAccessor then not c.fromSource() else any()) |
There was a problem hiding this comment.
This same pattern is also used in SsaImpl.qll. Should it be refactored into a predicate?
There was a problem hiding this comment.
The code in SsaImpl.qll will go away once we adopt the shared variable capture library, which is expected to happen next quarter.
| target = c.getTarget() and | ||
| not target.hasBody() | ||
| | | ||
| if target instanceof AddEventAccessor then not target.fromSource() else any() |
There was a problem hiding this comment.
Why do we need to special case AddEventAccessor?
There was a problem hiding this comment.
Because default event accessors will not invoke the callbacks that they are provided, merely add/remove them from the list of callbacks.
There was a problem hiding this comment.
Why don't we need to special case RemoveEventAccessor?
There was a problem hiding this comment.
Whoops, that's definitely a mistake. I think I will simply include all accessors, since the same holds for auto-generated getters/setters.
Previously, we would assume that calls to library methods would invoke their passed delegates. This is now generalized to include any method without a body (i.e., also abstract methods and interface methods).