Skip to content

Java Automodel extraction: remove primitives in framework mode #14849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kaeluka
Copy link
Contributor

@kaeluka kaeluka commented Nov 20, 2023

This removes some candidates and examples from framework mode, based on feedback from the Java team (see backref).

The suggestion was to drop primitive values from consideration; additionally, as a drive-by, this PR also removes source candidates of methods return values when the method is returning void.

I've asked Tony for a review, as he suggested removing this. The PR is quite short. LMK if you have any questions 👍 🙂

- [x] Remove return-value source endpoints for primitive methods in framework mode
- [x] Remove return-value source candidates for void methods in framework mode
- [x] Remove parameter-source-candidates for primitive parameters in framework mode

…owing how primitives are currently candidates
@github-actions github-actions bot added the Java label Nov 20, 2023
@kaeluka kaeluka marked this pull request as ready for review November 20, 2023 14:11
@kaeluka kaeluka requested a review from a team as a code owner November 20, 2023 14:11
@kaeluka kaeluka requested a review from atorralba November 20, 2023 14:12
@kaeluka kaeluka added the no-change-note-required This PR does not need a change note label Nov 20, 2023
Copy link
Contributor

@atorralba atorralba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I added a couple of comments for your consideration.

@kaeluka kaeluka merged commit 68a7734 into main Nov 27, 2023
@kaeluka kaeluka deleted the kaeluka/automodel-extraction-skip-primitive-types-candidates branch November 27, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants