Go: Change how we refer to a query in a change note #14890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbo
previously approved these changes
Nov 23, 2023
mbg
previously approved these changes
Nov 23, 2023
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| ### Minor Analysis Improvements | |||
|
|
|||
| * Added the [gin cors](https://github.com/gin-contrib/cors) library to the CorsMisconfiguration.ql query | |||
| * Added the [gin cors](https://github.com/gin-contrib/cors) library to the experimental query "CORS misconfiguration" (`go/cors-misconfiguration`). | |||
There was a problem hiding this comment.
Should CORS be capitalised in "gin CORS" while we are at it? (Perhaps that would also be better worded as "CORS for gin" or similar.)
There was a problem hiding this comment.
Good point. It doesn't seem to have a name that people refer to it by. The title of the repo's readme is "CORS gin's middleware" which doesn't make sense to me. I've gone with gin-contrib/cors, as that is how people tend to talk about it, and it makes it clear that it isn't one of the many other library for CORS with gin.
mbg
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.