C++: Add Taint through int -> bool casts #14904
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final step in undoing the workaround in https://github.com/github/codeql/pull/14886/files#diff-40e2016a464c1cf96ccb2a7469f1d6d2da1768ab2f355c8beb3bd0050ecd6a18R31 we add taint-flow through the implicit integer to boolean cast generated in a snippet such as:
This is necessary because we generate IR that's equivalent to:
and since we already have taint-flow from
x
to!x
, the additional taint fromx
tox != 0
ensures that we get flow to the result of the condition.