C#: Prefer assembly version over netcore version in conflict resolution #14991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The first commit shows a definite improvement in compilation errors in DCA. The second one made things worse, so removing that from the PR. |
tamasvajk
force-pushed
the
standalone/prefer-assembly-version-over-netcore-version
branch
from
54a576c to
db22478
Compare
tamasvajk
commented
Dec 4, 2023
| @@ -1,5 +1,6 @@ | |||
| | /avalara.avatax/21.10.0/lib/netstandard20/Avalara.AvaTax.netstandard20.dll | | |||
| | /microsoft.bcl.asyncinterfaces/6.0.0/lib/netstandard2.1/Microsoft.Bcl.AsyncInterfaces.dll | | |||
| | /microsoft.netcore.app.ref/3.1.0/ref/netcoreapp3.1/System.Data.DataSetExtensions.dll | | |||
There was a problem hiding this comment.
This change will be reverted back to the 7.0.2 version in #14994.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is changing the sorting of conflicting assemblies. Assembly version now takes precedence over .net core version.