Skip to content

Java: Deprecate or remove imports of dataflow library copies #15026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Java: Deprecate or remove imports of dataflow library copies #15026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b8f3f3
Deprecate or remove imports of dataflow library copies
egregius313 Dec 5, 2023
aebbc7d
Add private imports to prevent compile warnings
egregius313 Dec 6, 2023
1526da5
Deprecation change note
egregius313 Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .../ql/lib/change-notes/2023-12-08-deprecate-reexport-of-old-dataflow-libraries.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: deprecated
---
* Imports of the old dataflow libraries (e.g. `semmle.code.java.dataflow.DataFlow2`) have been deprecated in the libraries under the `semmle.code.java.security` namespace.
3 changes: 2 additions & 1 deletion java/ql/lib/semmle/code/java/frameworks/JsonIo.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
import java
import semmle.code.java.Maps
import semmle.code.java.dataflow.DataFlow
import semmle.code.java.dataflow.DataFlow2
deprecated import semmle.code.java.dataflow.DataFlow2
private import semmle.code.java.dataflow.DataFlow2

/**
* The class `com.cedarsoftware.util.io.JsonReader`.
Expand Down
1 change: 0 additions & 1 deletion java/ql/lib/semmle/code/java/regex/RegexFlowConfigs.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import java
import semmle.code.java.dataflow.ExternalFlow
private import semmle.code.java.dataflow.DataFlow
private import semmle.code.java.dataflow.DataFlow2
private import semmle.code.java.security.SecurityTests

private class ExploitableStringLiteral extends StringLiteral {
Expand Down
4 changes: 2 additions & 2 deletions java/ql/lib/semmle/code/java/security/AndroidIntentRedirectionQuery.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

import java
import semmle.code.java.dataflow.FlowSources
import semmle.code.java.dataflow.DataFlow2
deprecated import semmle.code.java.dataflow.DataFlow2
import semmle.code.java.dataflow.TaintTracking
import semmle.code.java.dataflow.TaintTracking3
deprecated import semmle.code.java.dataflow.TaintTracking3
import semmle.code.java.security.AndroidIntentRedirection

/**
Expand Down
2 changes: 1 addition & 1 deletion java/ql/lib/semmle/code/java/security/CleartextStorageCookieQuery.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import java
import semmle.code.java.dataflow.DataFlow
import semmle.code.java.dataflow.DataFlow3
deprecated import semmle.code.java.dataflow.DataFlow3
import semmle.code.java.security.CleartextStorageQuery

private class CookieCleartextStorageSink extends CleartextStorageSink {
Expand Down
2 changes: 0 additions & 2 deletions java/ql/lib/semmle/code/java/security/CleartextStorageQuery.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
/** Provides classes and predicates to reason about cleartext storage vulnerabilities. */

import java
private import semmle.code.java.dataflow.DataFlow4
private import semmle.code.java.dataflow.TaintTracking
private import semmle.code.java.dataflow.TaintTracking2
private import semmle.code.java.security.SensitiveActions

/** A sink representing persistent storage that saves data in clear text. */
Expand Down
3 changes: 2 additions & 1 deletion java/ql/lib/semmle/code/java/security/HardcodedCredentialsSourceCallQuery.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@

import java
import semmle.code.java.dataflow.DataFlow
import semmle.code.java.dataflow.DataFlow2
deprecated import semmle.code.java.dataflow.DataFlow2
private import semmle.code.java.dataflow.DataFlow2
import HardcodedCredentials

/**
Expand Down
3 changes: 2 additions & 1 deletion java/ql/lib/semmle/code/java/security/XmlParsers.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

import java
import semmle.code.java.dataflow.DataFlow
import semmle.code.java.dataflow.DataFlow3
deprecated import semmle.code.java.dataflow.DataFlow3
private import semmle.code.java.dataflow.DataFlow3
private import semmle.code.java.dataflow.RangeUtils

private module Frameworks {
Expand Down
1 change: 0 additions & 1 deletion java/ql/src/experimental/Security/CWE/CWE-1004/SensitiveCookieNotHttpOnly.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import java
import semmle.code.java.dataflow.FlowSteps
import semmle.code.java.frameworks.Servlets
import semmle.code.java.dataflow.TaintTracking
import semmle.code.java.dataflow.TaintTracking2
import MissingHttpOnlyFlow::PathGraph

/** Gets a regular expression for matching common names of sensitive cookies. */
Expand Down