Skip to content

C#: Update @name for two queries #1509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 27, 2019
Merged

C#: Update @name for two queries #1509

merged 2 commits into from
Jun 27, 2019

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Jun 27, 2019

No description provided.

@hvitved hvitved added the C# label Jun 27, 2019
@hvitved hvitved requested a review from aibaars June 27, 2019 08:04
@hvitved hvitved requested a review from a team as a code owner June 27, 2019 08:04
@aibaars
Copy link
Contributor

aibaars commented Jun 27, 2019

@felicity-semmle @hvitved This also requires a change to the change notes, right?

@hvitved
Copy link
Contributor Author

hvitved commented Jun 27, 2019

This also requires a change to the change notes, right?

Shouldn't be needed; these queries were added in 1.21.

@aibaars
Copy link
Contributor

aibaars commented Jun 27, 2019 •
edited
Loading

Well adding a new query is also a change ...
See #1501 the change notes already mention these queries, but with the old name.

aibaars
aibaars requested changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@aibaars aibaars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the change notes in https://github.com/Semmle/ql/blob/rc/1.21/change-notes/1.21/analysis-csharp.md

@hvitved hvitved force-pushed the csharp/rename-queries branch from d6cde8e to b6cf135 Compare June 27, 2019 08:23
@hvitved
Copy link
Contributor Author

hvitved commented Jun 27, 2019

Well adding a new query is also a change

You are right, forgot about that.

aibaars
aibaars previously approved these changes Jun 27, 2019
View reviewed changes
@hvitved hvitved removed the request for review from a team June 27, 2019 08:31
@felicitymay
Copy link
Contributor

This also change needs a PR to update the change notes in the code repository...

@aibaars aibaars added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Jun 27, 2019
@felicitymay
Copy link
Contributor

All LGTM. Thanks for the correction.

@semmle-qlci semmle-qlci merged commit 74ad6e8 into github:rc/1.21 Jun 27, 2019
@hvitved hvitved deleted the csharp/rename-queries branch June 27, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felicitymay felicitymay felicitymay approved these changes

@aibaars aibaars aibaars approved these changes

Assignees
No one assigned
Labels
C# depends on internal PR This PR should only be merged in sync with an internal Semmle PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hvitved @aibaars @felicitymay @semmle-qlci