InlineFlowTest: Allow for custom getArgString
#15090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jketema
previously approved these changes
Dec 13, 2023
I have done that now, pushing a dummy "trigger CI" commit, and it worked fine. I'll revert the trigger commit again. |
hvitved
force-pushed
the
inline-flow-test-get-arg-string
branch
from
548784b to
28a2d05
Compare
MathiasVP
previously approved these changes
Dec 14, 2023
yoff
previously approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Python 👍
I made two suggestions. They make the diff a little larger, but I think they express the intent better. If at some point ValueFlowTest should be updated to no longer use NoFlowConfig, it can be done in one central place. This is an imaginary example, though, and I do not know how likely such changes are, so I will approve even without it.
Co-authored-by: yoff <lerchedahl@gmail.com>
jketema
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When not using
DefaultFlowTest, it is useful to be able to implement a customgetArtStringpredicate.