C#: .NET8 Stubs update. #15100

michaelnebel · 2023-12-14T10:14:44Z

In this PR we update all the C# generated stubs.
The process was as follows

Delete all stub folders in test/resources/stubs
Run the make_stubs_all.py script and copy all the generated stubs to test/resources/stubs and add everything to the repo.
Update all options files to point to the new version of the stubs.
Make needed manual adjustments to generated and handwritten stubs to get everything to compile again <-- I think this is currently the closest we have been to able to automate the process.

A couple of interesting possibilities for improvements

The version numbers may be printed incorrectly in the .csproj files (I think this is due to ranges being used).
The appears to be some garbage stub code generated for the ServiceStack framework (I will look into this if time allows it).

…stub.

hvitved · 2023-12-15T09:33:24Z

csharp/ql/test/resources/stubs/ServiceStack.Common/8.0.0/ServiceStack.Common.cs

@@ -1436,15 +1436,11 @@ public class DefaultScripts : ServiceStack.Script.ScriptMethods, ServiceStack.Sc
            public long decrBy(long value, long by) => throw null;
            public long decrement(long value) => throw null;
            public long decrementBy(long value, long by) => throw null;
-            public object default(object returnTarget, object elseReturn) => throw null;


Is this because the stubgenerator fails to escape the name as @default?

Yes, I definitely thinks that is the case: https://github.com/ServiceStack/ServiceStack/blob/8134c682b3074b3e9525a269b8ba66427fee10e7/ServiceStack/src/ServiceStack.Common/Script/Methods/DefaultScripts.cs#L1630

I intend to do some follow up work on the stub generator to fix this.

hvitved · 2023-12-15T09:33:37Z

csharp/ql/test/resources/stubs/ServiceStack.Common/8.0.0/ServiceStack.Common.cs

            public System.Collections.Generic.IEnumerable<object> distinct(System.Collections.Generic.IEnumerable<object> items) => throw null;
            public double div(double lhs, double rhs) => throw null;
            public double divide(double lhs, double rhs) => throw null;
-            public object do(ServiceStack.Script.ScriptScopeContext scope, object expression) => throw null;


Same, @do.

hvitved · 2023-12-15T09:33:48Z

csharp/ql/test/resources/stubs/ServiceStack.Common/8.0.0/ServiceStack.Common.cs

@@ -1562,9 +1558,7 @@ public class DefaultScripts : ServiceStack.Script.ScriptMethods, ServiceStack.Sc
            public string httpPathInfo(ServiceStack.Script.ScriptScopeContext scope) => throw null;
            public string httpRequestUrl(ServiceStack.Script.ScriptScopeContext scope) => throw null;
            public string humanize(string text) => throw null;
-            public object if(object test) => throw null;


hvitved · 2023-12-15T09:33:53Z

csharp/ql/test/resources/stubs/ServiceStack.Common/8.0.0/ServiceStack.Common.cs

@@ -1846,10 +1840,7 @@ public class DefaultScripts : ServiceStack.Script.ScriptMethods, ServiceStack.Sc
            public object resolveContextArg(ServiceStack.Script.ScriptScopeContext scope, string name) => throw null;
            public object resolveGlobal(ServiceStack.Script.ScriptScopeContext scope, string name) => throw null;
            public object resolvePageArg(ServiceStack.Script.ScriptScopeContext scope, string name) => throw null;
-            public ServiceStack.Script.StopExecution return(ServiceStack.Script.ScriptScopeContext scope) => throw null;


hvitved · 2023-12-15T09:33:58Z

csharp/ql/test/resources/stubs/ServiceStack.Common/8.0.0/ServiceStack.Common.cs

@@ -1939,9 +1930,7 @@ public class DefaultScripts : ServiceStack.Script.ScriptMethods, ServiceStack.Sc
            public System.Collections.Generic.IEnumerable<object> thenByDescending(ServiceStack.Script.ScriptScopeContext scope, object target, object expression) => throw null;
            public System.Collections.Generic.IEnumerable<object> thenByDescending(ServiceStack.Script.ScriptScopeContext scope, object target, object expression, object scopeOptions) => throw null;
            public static System.Collections.Generic.IEnumerable<object> thenByInternal(string filterName, ServiceStack.Script.ScriptScopeContext scope, object target, object expression, object scopeOptions) => throw null;
-            public object throw(ServiceStack.Script.ScriptScopeContext scope, string message) => throw null;


hvitved · 2023-12-15T09:34:09Z

csharp/ql/test/resources/stubs/ServiceStack.Common/8.0.0/ServiceStack.Common.cs

@@ -3265,9 +3253,7 @@ public class ProtectedScripts : ServiceStack.Script.ScriptMethods
            public ServiceStack.Script.IgnoreResult Move(string from, string to) => throw null;
            public ServiceStack.Script.IgnoreResult Move(ServiceStack.Script.IOScript os, string from, string to) => throw null;
            public string mv(ServiceStack.Script.ScriptScopeContext scope, string from, string to) => throw null;
-            public object new (string typeName) => throw null;


hvitved · 2023-12-15T09:34:14Z

csharp/ql/test/resources/stubs/ServiceStack.Common/8.0.0/ServiceStack.Common.cs

@@ -3298,8 +3284,7 @@ public class ProtectedScripts : ServiceStack.Script.ScriptMethods
            public string textContents(ServiceStack.IO.IVirtualFile file) => throw null;
            public string touch(ServiceStack.Script.ScriptScopeContext scope, string target) => throw null;
            public static string TypeNotFoundErrorMessage(string typeName) => throw null;
-            public System.Type typeof(string typeName) => throw null;


hvitved · 2023-12-15T09:34:40Z

csharp/ql/test/resources/stubs/ServiceStack.Text/8.0.0/ServiceStack.Text.cs

@@ -1042,8 +1042,7 @@ public static partial class ListExtensions
    }
    public class LongRange : System.IEquatable<ServiceStack.LongRange>
    {
-        public virtual ServiceStack.LongRange<Clone>$() => throw null;


Looks like the stub generator should not emit this.

I will look into this problem as well (it is different from the previous ones).

This is because the a "clone" method is created for record class. It can't be invoked directly (only implicitly via the r with { ... } expression, so we should just avoid generating it.

Depending on what our goal is, it might not be enough to remove this method from the stubs.

The with { ... } expression can only be used with records. So if this class is not generated as a record class, then we won't be able to write new LongRange() with { ... } in the test files. (But I think we can live with this limitation)

github-actions bot added the C# label Dec 14, 2023

michaelnebel force-pushed the csharp/stubsrefresh branch 4 times, most recently from 1a71142 to 118238c Compare December 15, 2023 08:19

michaelnebel changed the title ~~C#: Stubs refresh.~~ C#: .NET8 Stubs update. Dec 15, 2023

michaelnebel added 6 commits December 15, 2023 10:02

C#: Update all generated stubs.

8967a09

C#: Make manual adjustments to the generated stubs.

0e6399e

C#: Modify System.Web.cs manual stub to avoid overlap with generated …

597a47b

…stub.

C#: Update/Add some hand-written stubs for CWE-079 and CWE-611.

588fe27

C#: Update options files.

3ead21f

C#: Update flowsummaries expected tests.

305e015

michaelnebel force-pushed the csharp/stubsrefresh branch from 118238c to 305e015 Compare December 15, 2023 09:02

michaelnebel marked this pull request as ready for review December 15, 2023 09:23

michaelnebel requested a review from a team as a code owner December 15, 2023 09:23

hvitved approved these changes Dec 15, 2023

View reviewed changes

michaelnebel merged commit d59b5a9 into github:main Dec 15, 2023

michaelnebel deleted the csharp/stubsrefresh branch December 15, 2023 09:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

C#: .NET8 Stubs update. #15100

C#: .NET8 Stubs update. #15100

Uh oh!

michaelnebel commented Dec 14, 2023 •

edited

Loading

Uh oh!

hvitved Dec 15, 2023

Uh oh!

michaelnebel Dec 15, 2023

Uh oh!

hvitved Dec 15, 2023

Uh oh!

hvitved Dec 15, 2023

Uh oh!

hvitved Dec 15, 2023

Uh oh!

hvitved Dec 15, 2023

Uh oh!

hvitved Dec 15, 2023

Uh oh!

hvitved Dec 15, 2023

Uh oh!

hvitved Dec 15, 2023

Uh oh!

michaelnebel Dec 15, 2023

Uh oh!

michaelnebel Dec 15, 2023

Uh oh!

tamasvajk Dec 15, 2023

Uh oh!

Uh oh!

C#: .NET8 Stubs update. #15100

C#: .NET8 Stubs update. #15100

Uh oh!

Conversation

michaelnebel commented Dec 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

michaelnebel commented Dec 14, 2023 •

edited

Loading