Skip to content

JavaScript: Add support for XML attributes in the data flow graph #15110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rvermeulen
Copy link
Contributor

@rvermeulen rvermeulen commented Dec 14, 2023

Model XML attributes similar to HTML attributes so we can reason about values flowing from/to XML attributes.

This is necessary for supporting Web frameworks relying on XML to define views such as SAP UI5.

@rvermeulen rvermeulen requested a review from a team as a code owner December 14, 2023 19:35
@github-actions github-actions bot added the JS label Dec 14, 2023
@erik-krogh erik-krogh added the no-change-note-required This PR does not need a change note label Dec 14, 2023
Copy link
Contributor

@erik-krogh erik-krogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

You're not adding any dataflow edges as part of this PR.
I assume that's on purpose (are the queries internal?).

@erik-krogh erik-krogh merged commit a700aa4 into github:main Dec 14, 2023
@rvermeulen
Copy link
Contributor Author

The edges will added as part of separate pack. Later we can think about merging that into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JS no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants