Skip to content

Java: Add the Map#replace and Map#replaceAll methods to MapMutator in Maps.qll #15126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 19, 2023
Merged

Java: Add the Map#replace and Map#replaceAll methods to MapMutator in Maps.qll #15126

merged 2 commits into from
Dec 19, 2023

Conversation

egregius313
Copy link
Contributor

Adds the replace and replaceAll methods of the java.util.Map interface to the MapMutator class in Maps.qll.

@github-actions github-actions bot added the Java label Dec 15, 2023
@egregius313 egregius313 force-pushed the egregius313/java/minor/add-replace-to-mapmutator branch from 77c32cb to d79dceb Compare December 19, 2023 15:22
@egregius313 egregius313 marked this pull request as ready for review December 19, 2023 15:22
@egregius313 egregius313 requested a review from a team as a code owner December 19, 2023 15:22
@egregius313 egregius313 force-pushed the egregius313/java/minor/add-replace-to-mapmutator branch from d79dceb to 8c4afd2 Compare December 19, 2023 15:23
atorralba
atorralba reviewed Dec 19, 2023
View reviewed changes
Copy link
Contributor

@atorralba atorralba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one very minor comment.

@egregius313 egregius313 force-pushed the egregius313/java/minor/add-replace-to-mapmutator branch from 8c4afd2 to a93d6dd Compare December 19, 2023 15:28
@egregius313 egregius313 merged commit 06544e9 into github:main Dec 19, 2023
@egregius313 egregius313 deleted the egregius313/java/minor/add-replace-to-mapmutator branch December 19, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@atorralba atorralba atorralba approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
documentation Java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egregius313 @atorralba