Python: Add scope entry definition nodes #15166
Conversation
yoff
force-pushed
the
python/add-scope-entry-definition-nodes
branch
from
0a57ee3 to
c7d0dab
Compare
otherwise we confuse captured variables in the single scope entry cfg node. Now we have one for each defined variable.
also, it is slightly incorrect...
yoff
force-pushed
the
python/add-scope-entry-definition-nodes
branch
from
c7d0dab to
07c88dc
Compare
|
Evaluation came back as an optimization 🎉 |
| @@ -484,8 +484,7 @@ predicate simpleLocalFlowStep(Node nodeFrom, Node nodeTo) { | |||
| * or at runtime when callables in the module are called. | |||
| */ | |||
| predicate simpleLocalFlowStepForTypetracking(Node nodeFrom, Node nodeTo) { | |||
| IncludePostUpdateFlow<PhaseDependentFlow<LocalFlow::localFlowStep/2>::step/2>::step(nodeFrom, | |||
There was a problem hiding this comment.
Can you give some more details? Ah, from looking over the implementation of LocalFlow::localFlowStep (src) that already does the PhaseDependentFlow + IncludePostUpdateFlow stuff 👍
The PR description starts "remove unnecessary post-processing" and it is this post-processing that was slightly incorrect (in addition to being unnecessary). As it has been removed, there are no slightly incorrect parts left :-) (🤞) |
|
Ah, usually the old version is past-tense, so it would be more natural to say "also, it was slightly incorrect" -- at least that would have made me understand straight away :) |
Good point, I will keep that convention in mind going forward 👍 |
otherwise we confuse captured variables
in the single scope entry cfg node. Now
we have one for each defined variable.