Skip to content

C# 12: Type alias [Test only] #15297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Jan 11, 2024

It turns out that type aliasing works out of the box.
The semantic model already contains the substituted types.
Should we consider to extract the alias directives (we have not done so up until now)?

@github-actions github-actions bot added the C# label Jan 11, 2024
@michaelnebel michaelnebel marked this pull request as ready for review January 11, 2024 17:56
@michaelnebel michaelnebel requested a review from a team as a code owner January 11, 2024 17:56
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to not extract the aliases, for now.

@michaelnebel michaelnebel merged commit 9f14c7c into github:main Jan 12, 2024
@michaelnebel michaelnebel deleted the csharp/typealias branch January 12, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants