Skip to content

Go: Add go.work file #15362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Go: Add go.work file #15362

merged 1 commit into from
Mar 3, 2024

Conversation

mbg
Copy link
Member

@mbg mbg commented Jan 17, 2024

Go 1.22 supports our setup with vendored dependencies in workspace mode. This PR adds a suitable workspace file for the extractor, which allows Go tooling to work correctly for the extractor.

@mbg mbg self-assigned this Jan 17, 2024
@github-actions github-actions bot added the Go label Jan 17, 2024
@smowton
Copy link
Contributor

smowton commented Jan 18, 2024

Seems sensible. Remind me what this adds compared to our current situation?

@mbg
Copy link
Member Author

mbg commented Jan 18, 2024

@smowton This allows e.g. gopls to work correctly with the extractor / VSCode.

smowton
smowton previously approved these changes Jan 18, 2024
@mbg mbg marked this pull request as ready for review February 28, 2024 17:27
@mbg mbg requested a review from a team as a code owner February 28, 2024 17:27
@mbg mbg force-pushed the mbg/go/add-go-work branch from 7a95dc4 to bda8a80 Compare March 1, 2024 15:29
@mbg mbg requested a review from smowton March 1, 2024 15:56
@mbg mbg merged commit 9c2322d into main Mar 3, 2024
@mbg mbg deleted the mbg/go/add-go-work branch March 3, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants