Skip to content

False positive fix for cpp/uninitialized-local #15463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bdrodes
Copy link
Contributor

@bdrodes bdrodes commented Jan 29, 2024

False positive fix for cpp/uninitialized-local to address unallocated pointer access to static methods.

@bdrodes bdrodes requested a review from a team as a code owner January 29, 2024 18:23
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments. Once my comment has been addressed we just need a DCA 🤞

bdrodes and others added 3 commits January 30, 2024 09:19
@bdrodes
Copy link
Contributor Author

bdrodes commented Jan 30, 2024

@MathiasVP starting DCA,

Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming the DCA run is clean.

@MathiasVP
Copy link
Contributor

DCA run was (as expected) quite uneventful. Merging!

@MathiasVP MathiasVP merged commit 4b5a203 into github:main Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants