Skip to content

Updated dotnet version to 8.0.101 #15475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 1, 2024
Merged

Updated dotnet version to 8.0.101 #15475

merged 7 commits into from
Feb 1, 2024

Conversation

henti
Copy link
Contributor

@henti henti commented Jan 30, 2024

This is a corresponding PR to https://github.com/github/semmle-code/pull/48786

@henti henti requested review from a team as code owners January 30, 2024 16:28
@github-actions github-actions bot added the C# label Jan 30, 2024
@tamasvajk
Copy link
Contributor

@henti I pushed an extra commit to this PR to fix the failing integration tests. Let's see the results of the new CI run...

@tamasvajk
Copy link
Contributor

There are some [build-stderr] Install the [8.0.101] .NET SDK or update [.../global.json] to match an installed SDK. errors on MacOS and Windows.

@michaelnebel
Copy link
Contributor

There are some [build-stderr] Install the [8.0.101] .NET SDK or update [.../global.json] to match an installed SDK. errors on MacOS and Windows.

Yeah, I think we need to bump QL submodule on the internal PR to verify that the tests will pass when the PRs are merged.

michaelnebel
michaelnebel previously approved these changes Jan 31, 2024
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tamasvajk
Copy link
Contributor

I've merged #15472, which adds further integration tests that depend on 8.0.0.

Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@henti henti merged commit 16e62e6 into main Feb 1, 2024
@henti henti deleted the henti/update_dotnet branch February 1, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants