Skip to content

Go: Include versions in newer Go version needed diagnostic #15492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

mbg
Copy link
Member

@mbg mbg commented Jan 31, 2024

This PR slightly improves the go/autobuilder/newer-go-version-needed diagnostic by including version information as well making it clearer what the versions relate to.

@mbg mbg self-assigned this Jan 31, 2024
@mbg mbg requested a review from a team as a code owner January 31, 2024 13:32
@github-actions github-actions bot added the Go label Jan 31, 2024
Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention this in the printf immediately below too

@mbg mbg requested a review from smowton January 31, 2024 17:46
@mbg mbg merged commit 73d0b7e into main Feb 1, 2024
@mbg mbg deleted the mbg/go/include-versions-in-newer-diagnostic branch February 1, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants