C#: Extract dependency restore telemetry data #15518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamasvajk
commented
Feb 5, 2024
| Parallel.ForEach(projects, new ParallelOptions { MaxDegreeOfParallelism = options.Threads }, project => | ||
| { | ||
| logger.LogInfo($"Restoring project {project}..."); | ||
| var res = dotnet.Restore(new(project, packageDirectory.DirInfo.FullName, ForceDotnetRefAssemblyFetching: true)); | ||
| assetFiles.AddRange(res.AssetsFilePaths); | ||
| lock (sync) |
There was a problem hiding this comment.
This is a small bugfix. We were previously updating assetFiles in the Parallel.ForEach without locking. (It's also needed for the successCount increment)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tamasvajk
commented
Feb 5, 2024
csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/DependencyManager.cs
Outdated
Show resolved
Hide resolved
csharp/extractor/Semmle.Extraction.CSharp/Extractor/Analyser.cs
Outdated
Show resolved
Hide resolved
michaelnebel
reviewed
Feb 6, 2024
csharp/extractor/Semmle.Extraction.CSharp/Extractor/Analyser.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Nebel <michaelnebel@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a somewhat hacky way of extracting dependency restoration related data into the database. When the dependency manager is executed, there are no trap files yet, so we store the extracted
(key, value)pairs in memory, and write it into the compilation trap file when that's created. The data is written into thecompilation_infotable, and then returned incs/telemetry/extraction-information.