Skip to content

Add supported build modes to extractor metadata #15532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

henrymercer
Copy link
Contributor

This is in preparation for the new starter workflow described in the buildless experience ADR where we will specify the build mode for each language explicitly. This metadata only affects runs where a --build-mode option is specified, which currently does not impact production.

Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, although — is there no equivalent file for the languages not included in this PR?

@henrymercer
Copy link
Contributor Author

Makes sense, although — is there no equivalent file for the languages not included in this PR?

Good question. The language pack specifications are split across the internal and external repo — the backlinked issue links the PR for updating the ones in the internal repo.

@henrymercer henrymercer merged commit 23921af into main Feb 7, 2024
@henrymercer henrymercer deleted the henrymercer/add-build-modes branch February 7, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants