C# Add missing Windows Forms implicit usings #15535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamasvajk
force-pushed
the
buildless/winforms-usings
branch
from
8c802d7 to
b8dbb8c
Compare
hvitved
reviewed
Feb 7, 2024
| @@ -173,6 +195,14 @@ private void DoInitialize() | |||
| || line.Contains("<ImplicitUsings>enable</ImplicitUsings>".AsSpan(), StringComparison.Ordinal) | |||
| || line.Contains("<ImplicitUsings>true</ImplicitUsings>".AsSpan(), StringComparison.Ordinal); | |||
|
|
|||
| // Determine if WPF is used. | |||
| useWpf = useWpf | |||
| || line.Contains("<UseWPF>true</UseWPF>".AsSpan(), StringComparison.Ordinal); | |||
There was a problem hiding this comment.
I wonder if we should use OrdinalIgnoreCase throughout instead?
There was a problem hiding this comment.
Seems to make sense. We already do case insensitive matching in regexes.
hvitved
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.