Bazel/CMake: auto detect all cc_binary/cc_test targets
#15536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redsun82
requested review from
criemen and
AlexDenisov
and removed request for
criemen
It turns out `bazel aquery` is not so well behaved on Windows, so we need to accept that it reports errors and exits with an error.
sashabu
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works by letting cmake generate a
BUILD.bazelfile with agenerate_cmakebazel target using the result of a bazel query.bazel aqueryis used so that only targets compatible with the detected platform are listed. This requires some JSON parsing though.