C++: Don't strip specifiers away in TFinalParameterUse
#15626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
commented
Feb 15, 2024
| @@ -452,7 +452,7 @@ private module IsModifiableAtImpl { | |||
| private predicate impl(CppType cppType, int indirectionIndex) { | |||
| exists(Type pointerType, Type base | | |||
| isUnderlyingIndirectionType(pointerType) and | |||
| cppType.hasUnderlyingType(pointerType, _) and | |||
| cppType.hasUnderlyingType(pointerType, false) and | |||
There was a problem hiding this comment.
This was a small drive-by optimization I did: Since we only ever care about non-glvalue types in this predicate there's no need to get both the glvalue and the prvalue version of the type as we compute this pipeline
MathiasVP
commented
Feb 15, 2024
| exists(CppType cppType | | ||
| cppType.hasUnspecifiedType(unspecified, _) and | ||
| isModifiableAt(cppType, indirectionIndex + 1) | ||
| cppType.hasUnderlyingType(underlying, false) and |
There was a problem hiding this comment.
The false here is a similar drive-by optimization just like here
jketema
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preparatory change to an upcoming PR I'm doing related to the "automatically block flow out of modelled functions" work. It won't really have any visible impact yet, so it should be a totally safe change.
The core of the change is that we were incorrectly calling
getUnspecifiedTypeinstead ofgetUnderlyingTypewhen checking whether a parameter could be written to. CallinggetUnspecifiedTypeis wrong since, in addition to resolve typedefs, it also strips offconstspecifiers.Instead, we should be calling
getUnderlyingTypesince that only resolves typedefs.DCA looks uneventful (as expected).