Move the JS java tests to be a proper java_test target.
#15627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we had a `sh_test` wrapping the `java_test` to do some setup. This was extremely brittle on Windows, and relied on getting a deploy jar from `java_test`. This breaks when updating to Bazel 7, where the ability to get a deploy jar from `java_test` was removed. Therefore, we now do all the test setup in `AllTests.java` instead. This is much cleaner, and shouldn't break as easily.
|
I tested internally that the test still passes on Linux and Windows, and it does :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we had a
sh_testwrapping thejava_testto do some setup. This was extremely brittle on Windows, and relied on getting a deploy jar fromjava_test. This breaks when updating to Bazel 7, where the ability to get a deploy jar fromjava_testwas removed. Therefore, we now do all the test setup inAllTests.javainstead. This is much cleaner, and shouldn't break as easily.