Cpp non constant format as path query #15628
Merged
+200
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he output alert to be more precise on what is being alerted. Minor changes to the query itself to avoid redundancies with argv.
… cpp-non-constant-format-as-path-query # Conflicts: # cpp/ql/src/Likely Bugs/Format/NonConstantFormat.ql
…re accidentally removed in prior merge with other non-const branches)
MathiasVP
reviewed
Feb 19, 2024
|
It looks like the DCA run shows no regressions? Does that mean we are set on this one? |
geoffw0
previously approved these changes
Feb 29, 2024
I don't see any failures in Mathias's run, but it failed to analyze two projects. Would be good to have a brief change note (and that'll make CI happy). |
They both failed before the analyze step, so I wouldn't worry too much about that. |
|
I've added a change note now. Might as well just get this one merged ourselves given that Ben is on vacation. |
MathiasVP
added
the
depends on internal PR
|
I've accepted the required changes in the PR, and I've opened an internal PR to accept the internal test changes. |
MathiasVP
approved these changes
Mar 1, 2024
geoffw0
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifying the cpp non const format query to be a path query.