Dataflow: Fix flow-feature bug for parameterless static functions #15632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschackmull
added
the
no-change-note-required
MathiasVP
approved these changes
Feb 16, 2024
I was about to say no (famous last words), but looking at the dependency, there's actually likely to be many cases where I would expect the size estimate of |
|
ping @bdrodes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flow features
FeatureHasSourceCallContextandFeatureEqualSourceSinkCallContextdidn't work for parameterless static functions. This bug is fairly obscure, since most use-cases of those two features expect the source to be a parameter, and that's why it has gone undetected for quite some time.