C#: Download latest dotnet SDK when missing #15692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamasvajk
commented
Feb 22, 2024
csharp/autobuilder/Semmle.Autobuild.CSharp/StandaloneBuildRule.cs
Outdated
Show resolved
Hide resolved
csharp/autobuilder/Semmle.Autobuild.CSharp/StandaloneBuildRule.cs
Outdated
Show resolved
Hide resolved
hvitved
reviewed
Feb 23, 2024
|
|
||
| if (ensureDotNetAvailable) | ||
| { | ||
| return DownloadDotNetVersion(builder, installDir, Constants.LatestDotNetSdkVersion, needExactVersion: false); |
There was a problem hiding this comment.
Why can't we simply skip the --version argument to the install script? That should install the latest version.
There was a problem hiding this comment.
I haven't tried that, but I think it wouldn't work. You can pass latest to -Version, but you need to also specify the -Channel. Also, I think it's somewhat safer to control the exact fallback version, and then the version that we use seems to be a good candidate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the dotnet SDK downloading in buildless mode. If there's no
dotnetCLI on the machine, it downloads the latest one as if that version was specified in theglobal.json. This way buildless extraction doesn't depend ondotnetbeing installed beforehand onto the machine.