Skip to content

C#: Compiler generated statements. #15696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 28, 2024

Conversation

michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Feb 22, 2024

In this PR we

  • Merge the expr_compiler_generated into compiler_generated.
  • Make support for compiler generated statements and add compiler generated statements to the compiler_generated table.
  • Tag synthetic empty block statements as being compiler generated.

Before merge, we need to

  • Update stats.
  • Run DCA.

@github-actions github-actions bot added the C# label Feb 22, 2024
@michaelnebel michaelnebel force-pushed the csharp/compilergeneratedstmt branch 4 times, most recently from d08d8de to bb07e5f Compare February 23, 2024 10:16
@michaelnebel michaelnebel marked this pull request as ready for review February 23, 2024 11:52
@michaelnebel michaelnebel requested a review from a team as a code owner February 23, 2024 11:52
@michaelnebel
Copy link
Contributor Author

Requesting review now in case we want to do this differently (still need to recreate DB stats and run DCA).

@michaelnebel michaelnebel force-pushed the csharp/compilergeneratedstmt branch from a3b4d5b to f5eb766 Compare February 23, 2024 12:37
@michaelnebel
Copy link
Contributor Author

I will make some new stats.

@michaelnebel michaelnebel force-pushed the csharp/compilergeneratedstmt branch from f5eb766 to cba2477 Compare February 26, 2024 12:51
@michaelnebel
Copy link
Contributor Author

DCA looks good.

@michaelnebel michaelnebel requested a review from hvitved February 27, 2024 08:18
@michaelnebel michaelnebel merged commit 65ec809 into github:main Feb 28, 2024
@michaelnebel michaelnebel deleted the csharp/compilergeneratedstmt branch February 28, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants