Skip to content

Automodel: Add four more sink types. #15732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

max-schaefer
Copy link
Contributor

No description provided.

@max-schaefer max-schaefer requested a review from jhelie February 27, 2024 09:13
@max-schaefer max-schaefer requested a review from a team as a code owner February 27, 2024 09:13
@github-actions github-actions bot added the Java label Feb 27, 2024
@max-schaefer max-schaefer requested a review from tausbn February 27, 2024 14:45
Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. Only thing I find slightly puzzling is the fact that the kinds you're removing from isKnownKind don't match up with the ones you're adding as subclasses of SinkType, but I'm sure you know what you're doing. 🙂

@max-schaefer
Copy link
Contributor Author

Only thing I find slightly puzzling is the fact that the kinds you're removing from isKnownKind don't match up with the ones you're adding as subclasses of SinkType, but I'm sure you know what you're doing. 🙂

The change to isKnownKind is meant to be a refactoring, since the current implementation basically just inlines the getKind predicate. If we don't inline it, we don't have to maintain two separate copies.

@max-schaefer max-schaefer merged commit f2935ca into main Feb 27, 2024
@max-schaefer max-schaefer deleted the max-schaefer/more-sink-types branch February 27, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants