-
Notifications
You must be signed in to change notification settings - Fork 1.8k
JS: Call graph improvements #15823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
JS: Call graph improvements #15823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RasmusWL
previously approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After talking this PR through offline, I think it looks reasonable. I have a minor suggestion for wording of a comment, but that can be considered more of a nitpick 😊
javascript/ql/lib/semmle/javascript/dataflow/internal/CallGraphs.qll
Outdated
Show resolved
Hide resolved
…hs.qll Co-authored-by: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com>
RasmusWL
approved these changes
Mar 8, 2024
RasmusWL
added a commit
to RasmusWL/codeql
that referenced
this pull request
Mar 12, 2024
RasmusWL
added a commit
to RasmusWL/codeql
that referenced
this pull request
Mar 12, 2024
RasmusWL
added a commit
to RasmusWL/codeql
that referenced
this pull request
Mar 15, 2024
RasmusWL
added a commit
to RasmusWL/codeql
that referenced
this pull request
Mar 15, 2024
RasmusWL
added a commit
to RasmusWL/codeql
that referenced
this pull request
Mar 18, 2024
RasmusWL
added a commit
to RasmusWL/codeql
that referenced
this pull request
Mar 18, 2024
RasmusWL
added a commit
that referenced
this pull request
Mar 19, 2024
JS: show test changes after #15823
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does two things:
SourceNode
other thanthis
inside a constructor (functions stored on that are instead seen as instance methods).new
.The tracking of objects affects the call graph directly, and also contributes to the
impliedReceiverStep
, which causes the host object to flow intothis
in the body of method:Evaluation shows neutral performance and about 24k new call edges and a few new alerts. The alerts I've looked at are due new TP call edges.