Skip to content

csharp update MaD for HttpRequestMessage #15851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

LWSimpkins
Copy link
Contributor

There is an autogenerated MaD for System.Net.Http.HttpRequestMessage constructor where Uri class is one of the parameters. However, it's missing the overloaded constructor where the parameter is a string URL.

Both versions of the constructor can have taint flow, such as for SSRF. This PR adds the missing MaD for the overloaded constructor.

@LWSimpkins LWSimpkins requested a review from a team as a code owner March 8, 2024 00:46
@github-actions github-actions bot added the C# label Mar 8, 2024
Copy link
Contributor

github-actions bot commented Mar 8, 2024

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",25,11862,67,9
+    System,"``System.*``, ``System``",25,11864,67,9
-    Totals,,31,13410,409,9
+    Totals,,31,13412,409,9
  • Changes to framework-coverage-csharp.csv:
- System,67,25,11862,,8,8,9,,,4,5,,33,1,17,3,4,9896,1966
+ System,67,25,11864,,8,8,9,,,4,5,,33,1,17,3,4,9898,1966

@michaelnebel michaelnebel self-requested a review March 8, 2024 09:00
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
I will just trigger a DCA run as well.

@michaelnebel
Copy link
Contributor

DCA looks good!

@michaelnebel michaelnebel merged commit 36a7755 into github:main Mar 8, 2024
@LWSimpkins LWSimpkins deleted the 54-csharp-add-missing-mad-for-httprequestmessage-upstream branch March 28, 2025 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants